Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DfC #653 Fixed. Added Infrastructure Encryption on Storage. Added Private Link Service Network Policies. Added DNS Proxy. Added Private DNS Zones. #791

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

chbragg
Copy link
Contributor

@chbragg chbragg commented Nov 6, 2023

Added KV Private DNS zone among many other Private DNS zones: #790
Fixed defender bug under "Discussion #653"
Added DNS Proxy on Azure Firewall and set it to use Azure DNS: #733
Added Storage Account Infrastructure Encryption: #773

Description

Defender for Cloud:
When deploying and re-deploying DfC, there are several errors that usually happen which are fixed here.

Storage Accounts:
Storage Accounts can only have infrastructure encryption enabled when created. Added code to enable that upon provisioning.

Private Link Service Network Policies:
In order to deploy services like AVD into one of the spokes, there needs to be an option to disable the Private Link Service Network Policies. Added that option and kept the defaults uniform to the Private Endpoint Network Policies.

Private DNS Zones:
Added many Private DNS zones to be used for Private Link

DNS Proxy:
Made the Azure Firewall a DNS Proxy. Azure Firewall will query Azure DNS
Forced all vNets to use the Azure Firewall as the DNS Server

UNABLE to test in Air-Gapped clouds.

Issue reference

The issue this PR will close: #653
The issue this PR will close: #733
The issue this PR will close: #773
The issue this PR will close: #790

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Added infra encryption to storage
Fixed defender bug under "Discussion #653"
Added KV Private DNS zone
@chbragg chbragg requested a review from a team as a code owner November 6, 2023 14:50
Added additional Private DNS zones for Private Link
Added VNet configuration to use Azure Firewall for DNS
Made the Azure Firewall a DNS Proxy and forwarded DNS to Azure DNS
@chbragg chbragg changed the title DfC #653 Fixed. Added Infrastructure Encryption on Storage. Added Private Link Service Network Policies DfC #653 Fixed. Added Infrastructure Encryption on Storage. Added Private Link Service Network Policies. Added DNS Proxy. Added Private DNS Zones. Nov 22, 2023
@mikedzikowski mikedzikowski changed the base branch from main to privatedns-dzikowski January 4, 2024 16:51
@mikedzikowski
Copy link
Contributor

merging into branch to do updates

@mikedzikowski mikedzikowski merged commit a8a6a9a into Azure:privatedns-dzikowski Jan 4, 2024
@chbragg chbragg deleted the chbragg-DefendFix+NetPolicyAdd+StorageEnc branch January 4, 2024 16:57
jamasten pushed a commit that referenced this pull request Jan 13, 2024
…rtal UI Selector in the mlz.portal.json (#796)

* DfC #653 Fixed. Added Infrastructure Encryption on Storage. Added Private Link Service Network Policies. Added DNS Proxy. Added Private DNS Zones. (#791)

* Added Private Link Service Network policies
Added infra encryption to storage
Fixed defender bug under "Discussion #653"
Added KV Private DNS zone

* Fixed bug in Defender security notifications
Added additional Private DNS zones for Private Link
Added VNet configuration to use Azure Firewall for DNS
Made the Azure Firewall a DNS Proxy and forwarded DNS to Azure DNS

* updates for testing private dns and private link

* updates for testing private link

* vault core replace

* deployment condition for rsv dns

* name fix privateLinkEndpointName

* test updates dns

* testing dns group

* build json for private dns updates

* update portal location

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: chbragg <[email protected]>
Co-authored-by: github-actions <[email protected]>
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
…rtal UI Selector in the mlz.portal.json (Azure#796)

* DfC Azure#653 Fixed. Added Infrastructure Encryption on Storage. Added Private Link Service Network Policies. Added DNS Proxy. Added Private DNS Zones. (Azure#791)

* Added Private Link Service Network policies
Added infra encryption to storage
Fixed defender bug under "Discussion Azure#653"
Added KV Private DNS zone

* Fixed bug in Defender security notifications
Added additional Private DNS zones for Private Link
Added VNet configuration to use Azure Firewall for DNS
Made the Azure Firewall a DNS Proxy and forwarded DNS to Azure DNS

* updates for testing private dns and private link

* updates for testing private link

* vault core replace

* deployment condition for rsv dns

* name fix privateLinkEndpointName

* test updates dns

* testing dns group

* build json for private dns updates

* update portal location

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: chbragg <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants