This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Add tests for two more Storage resource types, and fixes to support #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
requested review from
babbageclunk,
devigned,
matthchr and
theunrepentantgeek
as code owners
November 10, 2020 05:31
Porges
changed the title
Add tests for two more storage types, and fixes to support
Add tests for two more storage resource types, and fixes to support
Nov 10, 2020
Porges
commented
Nov 10, 2020
Porges
commented
Nov 10, 2020
matthchr
approved these changes
Nov 10, 2020
Consider adding samples for the two new resource types in addition to tests? |
Porges
changed the title
Add tests for two more storage resource types, and fixes to support
Add tests for two more Storage resource types, and fixes to support
Nov 11, 2020
matthchr
approved these changes
Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageAccountsBlobService
andStorageAccountsBlobServicesContainer
resource types.autorest
library does not check this and will give back an authorizer that does not work.Outstanding items
We need to think about how to handle resources like
StorageAccountsBlobService
better. It must be named"default"
to work but this is not enforced at the moment.One idea is that we could merge this into the
StorageAccount
resource type so that it can be configured there, and the controller takes care of creating it separately.Another issue is that the name is not going to be unique in Kubernetes. For resources with an owner we might need to scope the name under the owner name, but I’m not sure that this is possible; the object is created in Kubernetes before we can touch the name. The user can set AzureName to "default" and Name to something else but this is not obvious.
I opened an issue for this here: #324