This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add a pipeline stage to check for remaining AnyType instances #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
requested review from
devigned,
matthchr,
Porges and
theunrepentantgeek
as code owners
Pull Request Test Coverage Report for Build 189421071
💛 - Coveralls |
Porges
reviewed
Jul 30, 2020
hack/generator/azure-arm.yaml
Outdated
| @@ -23,6 +23,115 @@ exportFilters: | |||
| group: definitions | |||
| name: ResourceBase | |||
| because: this type is not used | |||
|
|
|||
| # Exclusions for packages that currently produce types including AnyType | |||
There was a problem hiding this comment.
Good call - adding that!
Porges
approved these changes
Jul 30, 2020
Raises an error with the containing packages (so they can be added to the filtering) if any are found. Added exclusions in azure-arm.yaml for all groups/versions that fail at the moment. This gives us a list of the packages that need to be worked through. If you want to see the specific types containing AnyType run with verbosity level 2 or higher. (Adjusted the type filtering logging level up to 3 to avoid drowning in skipped types at the same time.)
babbageclunk
force-pushed
the
forbid-anytypes
branch
from
dbaed6b to
da89bec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises an error with the containing packages (so they can be added to the filtering) if any are found.
Added exclusions in azure-arm.yaml for all groups/versions that fail at the moment. This gives us a list of the packages that need to be worked through.
If you want to see the specific types containing AnyType run with verbosity level 2 or higher. (Adjusted the type filtering logging
level up to 3 to avoid drowning in skipped types at the same time.)