Update charts to use firewall parameters in mysql and postgresql instances #98
Conversation
Due to changes for Azure/open-service-broker-azure#146 we need to specify firewall rules if the service will be used outside of Azure as is the case when running minikube. Previous default was 0.0.0.0 to 255.255.255.255 so those values are used here.
There was a problem hiding this comment.
@jeremyrickard technically OSBA v0.5.0-alpha, which we haven't released yet, would be needed for this to work. But since there's no harm in passing extra, unrecognized parameters in a provisioning request, and the values specified here are the same as the values previously hardcoded into OSBA, this should be ok. LGTM and will merge pending CI.
|
@krancour yeah totally. I was just adding this PR so it was ready to go for when we release the new OSBA version (would need to patch it when we do, wasn't sure what the version was going to be). I'm OK leaving it until we release or merging now, since we will ignore the params as you mentioned. |
|
The nature of the changes make this safe to merge. We just need to be mindful of future similar PRs that might utilize features found in a version of OSBA that the OSBA chart doesn't yet install. That's all. This is g2g. |
…ances (Azure#98) * Updating chart to use public image Fixes Azure#66 * Updating charts to provide firewall start/end ranges. Due to changes for Azure/open-service-broker-azure#146 we need to specify firewall rules if the service will be used outside of Azure as is the case when running minikube. Previous default was 0.0.0.0 to 255.255.255.255 so those values are used here.
Due to changes for Azure/open-service-broker-azure#146
we need to specify firewall rules if the service will be used outside of Azure
as is the case when running minikube. Previous default was 0.0.0.0 to 255.255.255.255
so those values are used here.