Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Nested Mutations/Nested Create feature #2090

Closed
severussundar opened this issue Mar 11, 2024 · 0 comments · Fixed by #2103
Closed

Rename Nested Mutations/Nested Create feature #2090

severussundar opened this issue Mar 11, 2024 · 0 comments · Fixed by #2103
Assignees
@severussundar
Labels
Multiple mutations Fixes/enhancements related to nested mutations.
Milestone
0.12rc

Comments

@severussundar
Copy link
Contributor

Rename nested mutations and nested create references in the all the relevant places as this issue graphql/graphql-spec#252 in the graphql specs contradicts with what we are calling as nested mutations.
@severussundar severussundar added the Multiple mutations Fixes/enhancements related to nested mutations. label Mar 11, 2024
@severussundar severussundar added this to the 0.12rc milestone Mar 11, 2024
@severussundar severussundar self-assigned this Mar 11, 2024
This was referenced Mar 11, 2024
Merged
Closed
Merged
@severussundar severussundar linked a pull request Mar 14, 2024 that will close this issue
Rename nested-mutations and nested-create to multiple-mutations and multiple-create respectively #2103
Merged
severussundar added a commit that referenced this issue Mar 20, 2024
@severussundar
Rename nested-mutations and nested-create to multiple-mutations and m…
b1d5aca 
…ultiple-create respectively (#2103)

## Why make this change?

-  Closes #2090
- Renames `nested-mutations` and `nested-create` to `multiple-mutations`
and `multiple-create` respectively.
- Nested Mutations has a significantly different meaning in the graphql
specs (as explained in issue
graphql/graphql-spec#252) compared to what we
are trying to achieve. Hence, the decision to rename.

## What is this change?

- All references to nested mutations/nested create - option name, field
names in config JSON, class names, comments in code have been renamed.

## How was this tested?

- Unit and Integration tests added as part of
#1983 has been updated to
validate the rename of CLI option, property in the config file, etc.

## Sample Commands


![image](https://github.com/Azure/data-api-builder/assets/11196553/7815bdb8-b0ca-409c-9b28-1101d5639130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@severussundar severussundar

Labels
Multiple mutations Fixes/enhancements related to nested mutations.
Projects
None yet
Milestone
0.12rc
2 participants
@seantleonard @severussundar