Skip to content

Commit

Permalink
Fix undefined chat thread in main meeting when breakout room is immed…
Browse files Browse the repository at this point in the history
…iately closed (#5640) (#5642)

* Fix bug where chat thread is stuck on spinner when breakout room is quickly closed

* Fix code comments

* Change files
  • Loading branch information
mgamis-msft authored Feb 11, 2025
1 parent 1245771 commit cbadd3d
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Fix bug where chat thread is stuck on spinner when immediately returning to main meeting from breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Fix bug where chat thread is stuck on spinner when immediately returning to main meeting from breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ export class AzureCommunicationCallWithChatAdapter implements CallWithChatAdapte
if (!eventData.data || eventData.data.state === 'closed') {
if (
this.originCallChatAdapter &&
this.originCallChatAdapter?.getState().thread.threadId !== this.chatAdapter?.getState().thread.threadId
this.originCallChatAdapter?.getState().thread.threadId !== this.context.getState().chat?.threadId
) {
this.updateChatAdapter(this.originCallChatAdapter);
}
Expand All @@ -222,8 +222,9 @@ export class AzureCommunicationCallWithChatAdapter implements CallWithChatAdapte
this.chatAdapter?.offStateChange(this.onChatStateChange);
// Unassign chat adapter
this.chatAdapter = undefined;
// Set chat state to undefined to prevent showing chat thread of origin call
// Set chat state to undefined to ensure that the chat thread of the breakout room is not shown
this.context.unsetChatState();
// Update chat state to the origin call chat adapter
if (this.originCallChatAdapter) {
this.updateChatAdapter(this.originCallChatAdapter);
}
Expand Down

0 comments on commit cbadd3d

Please sign in to comment.