-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Runtime property references for resource and module names #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
reviewed
Nov 17, 2020
majastrz
reviewed
Nov 17, 2020
majastrz
reviewed
Nov 17, 2020
majastrz
reviewed
Nov 17, 2020
majastrz
reviewed
Nov 17, 2020
majastrz
reviewed
Nov 17, 2020
majastrz
reviewed
Nov 17, 2020
shenglol
reviewed
Nov 18, 2020
…ni/DeployTimeDepedencyVisitor
…ni/DeployTimeDepedencyVisitor
Codecov Report
@@ Coverage Diff @@
## main #928 +/- ##
==========================================
- Coverage 94.49% 94.48% -0.01%
==========================================
Files 336 338 +2
Lines 16835 16987 +152
Branches 14 14
==========================================
+ Hits 15908 16050 +142
- Misses 927 937 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ni/DeployTimeDepedencyVisitor
TSunny007
commented
Dec 2, 2020
…ni/DeployTimeDepedencyVisitor
majastrz
reviewed
Dec 15, 2020
…ni/DeployTimeDepedencyVisitor
miqm
reviewed
Dec 15, 2020
…ni/DeployTimeDepedencyVisitor
…hub.com/Azure/bicep into tsunkaraneni/DeployTimeDepedencyVisitor
…ni/DeployTimeDepedencyVisitor
…ni/DeployTimeDepedencyVisitor
shenglol
reviewed
Dec 22, 2020
shenglol
reviewed
Dec 22, 2020
shenglol
reviewed
Dec 22, 2020
…ni/DeployTimeDepedencyVisitor
anthony-c-martin
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #360
In addition, this blocks variables and multi-hop variable runtime references as well