Improve decompiler naming of resources: remove trailing "Name" from resources #8500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Bicep.Decompiler.IntegrationTests/Files/Working/output-loops/main.bicep
Show resolved
Hide resolved
StephenWeatherford
changed the title
src/Bicep.Decompiler.IntegrationTests/Bicep.Decompiler.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
...cep.Decompiler.IntegrationTests/Files/Working/101-1vm-2nics-2subnets-1vnet/azuredeploy.bicep
Show resolved
Hide resolved
anthony-c-martin
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Partial?) fix for #1591
This fix is to remove trailing "Name" from resource symbolic names for the common pattern which ends up decompiled as:
var vmName_var = '...'
resource vmName {
name: vmName_var
}
now goes to:
var vmName = '...'
resource vm {
name: vmName
}
I ran decompile on all templates in https://github.com/Azure/azure-quickstart-templates with these results:
Instances of variable names ending with "_var" went from 2623 to 489
Instances of resource names ending with "_resource" went from 1567 to 172
Microsoft Reviewers: Open in CodeFlow