Add ability to generate .bicep file from a Kubernetes manifest #7812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-c-martin
force-pushed
the
ant/kube_decomp
branch
4 times, most recently
from
bce2a4f to
e8af0e5
Compare
anthony-c-martin
force-pushed
the
ant/kube_decomp
branch
from
81b1eef to
0e34199
Compare
rynowak
reviewed
Aug 5, 2022
src/Bicep.LangServer/Handlers/ImportKubernetesManifestHandler.cs
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Aug 5, 2022
| public Task<ImportKubernetesManifestResponse> Handle(ImportKubernetesManifestRequest request, CancellationToken cancellationToken) | ||
| => helper.ExecuteWithTelemetryAndErrorHandling(async () => { | ||
| var bicepFilePath = Path.ChangeExtension(request.ManifestFilePath, ".bicep"); | ||
| var manifestContents = await File.ReadAllTextAsync(request.ManifestFilePath); |
There was a problem hiding this comment.
Is this the right thing to do from the VS Code POV? I expected this to take a URI and need to interact with VS Code APIs to get the document. eg: will this work in remote scenarios?
There was a problem hiding this comment.
It's a shortcut - the UI side brings up a file picker, meaning that you can only operate on on-disk files. Feels good enough for now, as there's no way I'm aware of to access the 'unsafe' behavior.
If we wanted to extend this in future, we'd need to either have the extension be aware of .yml files, or have the LSP send and receive the full file contents instead of sending/receiving URIs.
rynowak
reviewed
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importsEnabledExperimentalto VSIX package to enable/disable extensibility.importKubernetesManifestwhich takes a path to a kubernetes manifest, and generates a bicep file from it.Microsoft Reviewers: Open in CodeFlow