Port linter rule secure-params-in-nested-deploy #7741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenWeatherford
force-pushed
the
sw/linter-secure-nested2
branch
2 times, most recently
from
e121606 to
c317dc3
Compare
| @@ -330,6 +330,20 @@ | |||
| <data name="SecretsInParamsRule_MessageFormat" xml:space="preserve"> | |||
| <value>Parameter '{0}' may represent a secret (according to its name) and must be declared with the '@secure()' attribute.</value> | |||
| </data> | |||
| <data name="SecureParamsInNestedDeployRule_Description" xml:space="preserve"> | |||
There was a problem hiding this comment.
@ucheNkadiCode Here are the strings if you'd like to review
StephenWeatherford
force-pushed
the
sw/linter-secure-nested2
branch
from
c317dc3 to
75fc5df
Compare
StephenWeatherford
force-pushed
the
sw/linter-secure-nested2
branch
from
75fc5df to
d8e65ea
Compare
bhsubra
reviewed
Jul 31, 2022
src/Bicep.Core.UnitTests/Assertions/StringAssertionsExtensions.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Jul 31, 2022
src/Bicep.Core/Analyzers/Linter/Rules/SecureParamsInNestedDeploymentsRule.cs
Show resolved
Hide resolved
bhsubra
reviewed
Jul 31, 2022
src/Bicep.Core/Analyzers/Linter/Rules/SecureParamsInNestedDeploymentsRule.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Jul 31, 2022
src/Bicep.Core/Analyzers/Linter/Rules/SecureParamsInNestedDeploymentsRule.cs
Show resolved
Hide resolved
bhsubra
reviewed
Aug 1, 2022
src/Bicep.Core.UnitTests/Diagnostics/LinterRuleTests/SecureParamsInNestedDeploymentsTests.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Aug 1, 2022
src/Bicep.Core/Analyzers/Linter/Rules/SecureParamsInNestedDeploymentsRule.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Aug 1, 2022
src/Bicep.Core.UnitTests/Diagnostics/LinterRuleTests/SecureParamsInNestedDeploymentsTests.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Aug 1, 2022
src/Bicep.Core.UnitTests/Diagnostics/LinterRuleTests/SecureParamsInNestedDeploymentsTests.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Aug 1, 2022
src/Bicep.Core/Analyzers/Linter/Rules/SecureParamsInNestedDeploymentsRule.cs
Outdated
Show resolved
Hide resolved
bhsubra
reviewed
Aug 1, 2022
src/Bicep.Core/Analyzers/Linter/Rules/SecureParamsInNestedDeploymentsRule.cs
Outdated
Show resolved
Hide resolved
bhsubra
approved these changes
Aug 1, 2022
added 2 commits
August 1, 2022 21:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7223
Microsoft Reviewers: Open in CodeFlow