Fix for issue 7455 #7483
Merged
Fix for issue 7455 #7483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-c-martin
force-pushed
the
ant/7455
branch
from
71b1746 to
52e6a49
Compare
jeskew
reviewed
Jul 5, 2022
jeskew
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug I introduced with #7083.
In order to support better type validation for a lambda inside a parenthesized expression, I added logic to calculate the child declared type based on the parent declared type (e.g. so the declared type of the lambda in
map([123], (i => i))can be evaluated). Elsewhere the parent declared type is calculated based on child declared type - so in the place where these two pieces of logic meet, we get a cycle. To fix I've removed the logic I put in so that declared type is always calculated in a consistent direction.Closes #7455
Microsoft Reviewers: Open in CodeFlow