Add Log Analytics with Solutions and Diagnostics Settings Sample

[joshuawaddell]

Created a sample BICEP file that deploys the following:

• Log Analytics Workspace
• Diagnostic Settings for the Log Analytics Workspace that highlights a child resource
• Log Analytics Solutions for VM Insights and Container Insights

Naming convention for the resources based on ${uniqueString(resourceGroup().id)}

[alex-frankel]

Thanks for the contribution! Can you take a look at the comments and let us know if you have questions about the changes we are requesting?

[alex-frankel]

you don't need the string interpolation here. You can simply do:

name: vmInsights.name

[joshuawaddell]

updated to name: vmInsights.name

[alex-frankel]

Did you intend to have the parens () as part of the string here? In other words, the parens are going to be in the final calculated name and will show up in the resource names

[joshuawaddell]

I did intend to have the parens () as part of the string. In referencing the documentation on enabling Azure Monitor for VMs and Azure Monitor for Containers, that syntax is used. You can view the sample ARM Template at this link: https://docs.microsoft.com/en-us/azure/azure-monitor/insights/vminsights-enable-resource-manager

"apiVersion": "2015-11-01-preview", "type": "Microsoft.OperationsManagement/solutions", "location": "[parameters('WorkspaceLocation')]", "name": "[concat('VMInsights', '(', split(parameters('WorkspaceResourceId'),'/')[8], ')')]",

I tried using name: 'VMInsights-${logAnalyticsWorkspaceName}' as well as some other options, and the deployment errored out.

[alex-frankel]

Ah, ok. Looks good to me then.

[alex-frankel]

Also, I think tests are failing for the same reason as as #574. We may also need to hold this PR until #580 is merged

[alex-frankel]

Thanks for making the updates! We will wait until #580 is merged and see if the tests start passing. You may need to regenerate the bicep files with the new bicep CLI at that time.

[joshuawaddell]

Thanks for making the updates! We will wait until #580 is merged and see if the tests start passing. You may need to regenerate the bicep files with the new bicep CLI at that time.

Question: For the BICEP CLI, should that be the latest download, or will I need to compile a new version of the CLI?

[alex-frankel]

We aren't generating nightly builds, so you need to pull the latest from here: https://github.com/Azure/bicep/actions/runs/297578556

That being said, we are in a bit of a mixed state having just introduced type validation of resources, and we are still working out the kinks. If you are alright with it, we will edit this PR to get the tests passing then merge it in. Does that sound ok?

[alex-frankel]

Closing this since these files were also in #620, which have been merged to master