Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow example selection in playground #485

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Allow example selection in playground #485

merged 2 commits into from
Sep 14, 2020

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Sep 14, 2020 •
edited
Loading

samples

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         209      209           
  Lines        7170     7170           
=======================================
  Hits         6707     6707           
  Misses        463      463
Flag Coverage Δ
#dotnet 93.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@alex-frankel
Copy link
Collaborator

wow! that's so great

majastrz
majastrz reviewed Sep 14, 2020
View reviewed changes
src/playground/src/examples.ts
import example_201_vnet_peering from '../../../docs/examples/201/vnet-peering/main.bicep'
import example_201_sql from '../../../docs/examples/201/sql/main.bicep'

export const examples = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples [](start = 13, length = 8)

Any chance we could automatically populate the list at runtime or build time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there's a way to do this with webpack. I'm no expert with webpack unfortunately. Agree that we should do this, but I think I'll leave that as a future exercise.

majastrz
majastrz approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz
Copy link
Member

Yeah this is a great idea.

@anthony-c-martin anthony-c-martin merged commit 226982f into master Sep 14, 2020
@anthony-c-martin anthony-c-martin deleted the antmarti/playground_improvements branch September 14, 2020 20:18
@alex-frankel
Copy link
Collaborator

is the updated playground supposed to be live at https://bicepdemo.z22.web.core.windows.net/ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anthony-c-martin @codecov-commenter @alex-frankel @majastrz