Initial and *extremely* basic completions #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
commented
Sep 3, 2020
| return Task.FromResult(new CompletionList(completions, isIncomplete: false)); | ||
| } | ||
|
|
||
| public override Task<CompletionItem> Handle(CompletionItem request, CancellationToken cancellationToken) |
There was a problem hiding this comment.
The handle and can resolve are not used by us. They are intended to delay construction of documentation. Right now, we don't need it.
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 91.93% 91.06% -0.87%
==========================================
Files 199 201 +2
Lines 6708 6784 +76
==========================================
+ Hits 6167 6178 +11
- Misses 541 606 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
majastrz
commented
Sep 3, 2020
|
|
||
| private IEnumerable<CompletionItem> GetPrimitiveTypeCompletions() => LanguageConstants.DeclarationTypes.Values.Select(CreateTypeCompletion); | ||
|
|
||
| private IEnumerable<Symbol> GetAccessibleSymbols(SemanticModel model) |
There was a problem hiding this comment.
Next iterations will move this code into the core because it's related to how namespace lookups work during name binding. The dictionary is here to effectively remove inaccessible symbols from completion list. (Declaring a parameter called concat will prevent the concat() function from appearing in the list of completions.
anthony-c-martin
requested changes
Sep 3, 2020
anthony-c-martin
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added (as the title says) extremely basic completions support. The suggested completions currently include keywords, existing keyword snippets, primitive types and names of accessible symbols (vars, params, resources, and functions).
Limitations:
We have to start here because implementing a completion handler in the language server completely removes the built-in completions which provide some help right now.
Next steps:
requiredmetadata in swaggers.