Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix span calculation in ValidateSnippetCompletionAfterPlaceholderReplacements #3021

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Fix span calculation in ValidateSnippetCompletionAfterPlaceholderReplacements #3021

merged 1 commit into from
Jun 4, 2021

Conversation

anthony-c-martin
Copy link
Member

Closes #2947

majastrz
majastrz approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 996be17 into main Jun 4, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/issue2947 branch June 4, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snippet diagnostic spans are displayed incorrectly
2 participants
@anthony-c-martin @majastrz