Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block completions at positions where nodes should not be inserted (Part II) #2995

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Block completions at positions where nodes should not be inserted (Part II) #2995

merged 2 commits into from
Jun 4, 2021

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Jun 3, 2021

Closes #2671.

majastrz
majastrz approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shenglol shenglol merged commit 133e905 into main Jun 4, 2021
@shenglol shenglol deleted the shenglol/block-completions-part-II branch June 4, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not provide completions in locations where it can break syntaxes
2 participants
@shenglol @majastrz