Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves sql-database-with-management example #2970

Merged
merged 13 commits into from
Jun 2, 2021
Merged

Conversation

slavizh
Copy link
Contributor

@slavizh slavizh commented Jun 2, 2021

Contributing a Pull Request

  • code improvements
  • added usage of getSecret() instead of passing password from main bicep file
  • API versions updates
  • fixed incorrect property reference

Contributing an example

  • I have checked that there is not an equivalent example already submitted
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent!

name: 'sqlLogicalServer-${index}'
params: {
sqlLogicalServer: union(defaultSqlLogicalServerProperties, sqlLogicalServer)
password: sqlPassKeyVaults[index].getSecret(sqlLogicalServer.passwordFromKeyVault.secretName)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic that this works!

@alex-frankel alex-frankel merged commit 64233f8 into Azure:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants