Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TypeValidator in prep for #691 #2375

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Refactor TypeValidator in prep for #691 #2375

merged 1 commit into from
Apr 23, 2021

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Apr 23, 2021 •
edited
Loading

I wanted to simplify some of the argument passing in TypeValidator in preparation for #691 - where I'll need to add more arguments.

There should be no functional changes in this PR - it's just a refactor.

majastrz
majastrz approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit 30dd5af into main Apr 23, 2021
@anthony-c-martin anthony-c-martin deleted the antmarti/issue691_refactor branch April 23, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-c-martin @majastrz