Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #2311 - add location to firewall resource in examples/101/azurefirewall-create-with-zones #2312

Merged
merged 2 commits into from
Apr 19, 2021
Merged

fix issue #2311 - add location to firewall resource in examples/101/azurefirewall-create-with-zones #2312

merged 2 commits into from
Apr 19, 2021

Conversation

KaiWalter
Copy link
Contributor

this PR fixed issue #2311

Contributing an example

  • I have checked that there is not an equivalent example already submitted
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) April 19, 2021 14:09
anthony-c-martin
anthony-c-martin approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@anthony-c-martin anthony-c-martin merged commit 41f2a7b into Azure:main Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiWalter @anthony-c-martin