Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Snippet example for Shared Image Gallery #2310

Merged
merged 6 commits into from
Apr 24, 2021
Merged

New Snippet example for Shared Image Gallery #2310

merged 6 commits into from
Apr 24, 2021

Conversation

fberson
Copy link
Contributor

@fberson fberson commented Apr 17, 2021

Adding new Code Snippet for Shared Image Gallery Resource.

Contributing a snippet

  • I have only a single resource in my snippet
  • I have checked that there is not an equivalent snippet already submitted
  • I have used camelCasing unless I have a justification to use another casing style
  • I have placeholders values that correspond to their property names (e.g. dnsPrefix: 'dnsPrefix'), unless it's a property that MUST be changed or parameterized in order to deploy. In that case, I use 'REQUIRED' e.g. keyData
  • I have my symbolic name as the first tab stop ($1) in the snippet. e.g. res-aks-cluster.bicep
  • I have a resource name property equal to "name"

Adding new Code Snippet for Shared Image Gallery Resource.
@MarcusFelling MarcusFelling self-requested a review April 20, 2021 20:40
@MarcusFelling
Copy link
Collaborator

@fberson - thank you for another contribution! I will review once #2307 is completed.

Copy link
Collaborator

@MarcusFelling MarcusFelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this @fberson. The new standards have been merged. Please see requested changes below.

@MarcusFelling MarcusFelling reopened this Apr 24, 2021
@MarcusFelling MarcusFelling merged commit c879e40 into Azure:main Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants