Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove diagnostics.json, add main.combined.bicep #2257

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Remove diagnostics.json, add main.combined.bicep #2257

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84b59ca
Remove diagnostics.json, add main.combined.bicep
MarcusFelling Apr 14, 2021
40e7503
Explain how to autogenerate main.combined.bicep
Apr 14, 2021
9ae4e03
Remove step to run baselines before PR, already mentioned in step to …
Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,12 @@ If you'd like to contribute to the collection of snippets:

* Add a file named main.bicep
* The test will read this input file for snippet completions. It will take the replacement values listed in this file, replace them with their corresponding placeholder, then ensure Bicep reports no warnings or errors.
* E.g. [`res-aks-cluster/main.bicep`](./src/Bicep.LangServer.IntegrationTests/Completions/SnippetTemplates/res-aks-cluster/main.bicep)

* E.g. [`res-aks-cluster/main.bicep`](./src/Bicep.LangServer.IntegrationTests/Completions/SnippetTemplates/res-aks-cluster/main.bicep)
* Add a file named main.combined.bicep that contains the template combined with placeholder values. See [Updating test baselines](#updating-test-baselines) for information on how to automatically generate this file to match the format expected by the tests.
* E.g. [`res-aks-cluster/main.combined.bicep`](./src/Bicep.LangServer.IntegrationTests/Completions/SnippetTemplates/res-aks-cluster/main.combined.bicep)

* Add a file named diagnostics.json with empty brackets `[]`.
* E.g. [`res-aks-cluster/diagnostics.json`](./src/Bicep.LangServer.IntegrationTests/Completions/SnippetTemplates/res-aks-cluster/diagnostics.json)

* See [Running the tests](#running-the-tests) if you'd like to test locally before submitting a PR, and [Updating test baselines](#updating-test-baselines) for information on how to automatically update your snippet files to match the format expected by the tests.
* See [Running the tests](#running-the-tests) if you'd like to test locally before submitting a PR.

* Submit a PR for review

Expand Down