-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributed 3 new snippets for WVD resources #2256
Conversation
3 new snippets for Windows Virtual Desktop resources
Added the missing main.combined files for 3 WVD snippets
Thank you for your contributions @fberson! To simplify the snippet tests, we've removed the need to add the diagnostics.json file. I see you caught on and added the main.combined files 😊. Can you remove the 3 diagnostics.json files as well? Everything else looks good! FYI - This PR #2257 will be updating the contribution guide. |
Hi @MarcusFelling, thanks for the update! I've removed the 3 diagnostics.json files, but I there is still one error. Any clues? |
@fberson - to fix the failing tests trigger the Update Baselines workflow using your repo/branch. |
Added required properties hostPoolArmPath camel casing correction
3 new snippets for Windows Virtual Desktop resources
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing to documentation
Contributing an example
dotnet test
Contributing a feature