Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributed 3 new snippets for WVD resources #2256

Merged
merged 9 commits into from
Apr 15, 2021
Merged

Contributed 3 new snippets for WVD resources #2256

merged 9 commits into from
Apr 15, 2021

Conversation

fberson
Copy link
Contributor

@fberson fberson commented Apr 14, 2021

3 new snippets for Windows Virtual Desktop resources

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing to documentation

  • The contribution does not exist in any of the docs in either the root of the docs directory or the specs

Contributing an example

  • I have checked that there is not an equivalent example already submitted
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

fberson added 2 commits April 14, 2021 14:32
3 new snippets for Windows Virtual Desktop resources
Added the missing main.combined files for 3 WVD snippets
@MarcusFelling MarcusFelling self-requested a review April 14, 2021 14:52
@MarcusFelling
Copy link
Collaborator

MarcusFelling commented Apr 14, 2021

Thank you for your contributions @fberson! To simplify the snippet tests, we've removed the need to add the diagnostics.json file. I see you caught on and added the main.combined files 😊. Can you remove the 3 diagnostics.json files as well? Everything else looks good!

FYI - This PR #2257 will be updating the contribution guide.

@fberson
Copy link
Contributor Author

fberson commented Apr 14, 2021

Hi @MarcusFelling, thanks for the update! I've removed the 3 diagnostics.json files, but I there is still one error. Any clues?

@MarcusFelling
Copy link
Collaborator

@fberson - to fix the failing tests trigger the Update Baselines workflow using your repo/branch.

@MarcusFelling MarcusFelling merged commit d3ea3e8 into Azure:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants