Example Improvements related to issue #2135 (KeyVault secretsObject) #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alex-frankel thanks for the help getting this working!
realized I forgot the original issue.
alex-frankel
requested changes
Apr 5, 2021
| // https://github.com/Azure/bicep/issues/1754 | ||
|
|
||
| // Also: | ||
| // * KeyVaults secrets CANNOT BE EXPORTED into AMR/Bicep format. |
There was a problem hiding this comment.
Did you attempt export and secrets were not included?
| // * KeyVaults secrets CANNOT BE EXPORTED into AMR/Bicep format. | ||
| // * documentation: | ||
| // https://docs.microsoft.com/en-us/azure/templates/microsoft.keyvault/vaults/secrets?tabs=json | ||
| // * 201/key-vault-secret=create in pre-decompiled AMR format |
There was a problem hiding this comment.
I think you mean ARM not AMR
| @@ -1,3 +1,16 @@ | |||
| // | |||
| // v0.3 Bicep Known issue & work-around related to "secretsObject" | |||
There was a problem hiding this comment.
Let's get rid of this comment assuming we uncomment the default secret object in the array parameter
majastrz
approved these changes
Apr 29, 2021
alex-frankel
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alex-frankel thanks for the help getting this working!
Contributing an example
dotnet test