Improved error message on existing resource properties #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miqm
force-pushed
the
feature/existing-resources-error-message-1507
branch
from
f991267 to
5eedf2b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
- Coverage 95.11% 95.11% -0.01%
==========================================
Files 371 371
Lines 21962 21969 +7
Branches 15 15
==========================================
+ Hits 20890 20896 +6
- Misses 1072 1073 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
majastrz
reviewed
Mar 17, 2021
| @@ -1501,3 +1501,9 @@ resource vnet 'Microsoft.Network/virtualNetworks@2020-06-01' = { | |||
| } | |||
| } | |||
|
|
|||
| resource existngResProperty 'Mock.Rp/mockExistingResource@2020-01-01' = { | |||
| //@[28:69) [BCP081 (Warning)] Resource type "Mock.Rp/mockExistingResource@2020-01-01" does not have types available. |'Mock.Rp/mockExistingResource@2020-01-01'| | |||
There was a problem hiding this comment.
BCP081 [](start = 12, length = 6)
This isn't the diagnostic that was added (BCP167) Can probably change it to a real resource type to get that one.
…sources-error-message-1507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1507
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing a feature