Fixes for nested resource and scope interop issues #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
+ Coverage 95.03% 95.07% +0.04%
==========================================
Files 371 371
Lines 21671 21882 +211
Branches 15 15
==========================================
+ Hits 20594 20805 +211
Misses 1077 1077
Flags with carried forward coverage won't be shown. Click here to find out more.
|
majastrz
reviewed
Mar 11, 2021
| }, | ||
| "dependsOn": [ | ||
| "[resourceId('My.Rp/parentType/childType', split(format('{0}/{1}', 'basicParent', 'basicChild'), '/')[0], split(format('{0}/{1}', 'basicParent', 'basicChild'), '/')[1])]", | ||
| "[resourceId('My.Rp/parentType/childType', 'basicParent', 'basicChild')]", |
There was a problem hiding this comment.
basicParent [](start = 52, length = 11)
This was annoying me when I was converting some of our internal templates to Bicep.
majastrz
reviewed
Mar 11, 2021
| @@ -13,7 +13,7 @@ namespace Bicep.Core.UnitTests.Assertions | |||
| { | |||
| public static class JTokenAssertionsExtensions | |||
| { | |||
| public static JTokenAssertions Should(this JToken instance) | |||
| public static JTokenAssertions Should(this JToken? instance) | |||
There was a problem hiding this comment.
JToken [](start = 51, length = 6)
I'm guessing this led to usages of ! to suppress the nullness error all over the place. Worth going back to clean up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing a feature
Fixes #1810
This fixes the following issues: