Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example code in 06-creating-modules.md #1747

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

wayneforrester
Copy link
Contributor

Update code example under the Creating and consuming modules section as "ouput" should be an array and "outputs" does not have a "computedStorageName" property.

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing to documentation

  • The contribution does not exist in any of the docs in either the root of the docs directory or the specs

Contributing an example

  • I have checked that there is not an equivalent example already submitted
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

Update code example under the Creating and consuming modules section as "ouput" should be an array and "outputs" does not have a "computedStorageName" property.
Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thank you!

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #1747 (de21b50) into main (d17ce4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1747   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files         364      364           
  Lines       20446    20446           
  Branches       15       15           
=======================================
  Hits        19476    19476           
  Misses        970      970           
Flag Coverage Δ
dotnet 95.72% <ø> (ø)
typescript 26.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@wayneforrester
Copy link
Contributor Author

Glad to be able to help!

@alex-frankel alex-frankel reopened this Mar 5, 2021
@alex-frankel alex-frankel merged commit 778039e into Azure:main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants