Loop snippets #1647
Merged
Loop snippets #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
reviewed
Feb 27, 2021
| @@ -90,8 +111,9 @@ public override void VisitForSyntax(ForSyntax syntax) | |||
| case null: | |||
| // this is a property loop | |||
| this.propertyLoopCount += 1; | |||
| this.maximumPropertyLoopCount = Math.Max(this.maximumPropertyLoopCount, this.propertyLoopCount); | |||
There was a problem hiding this comment.
What's the purpose of maximumPropertyLoopCount? It is assigned but its value doesn't seem to be used anywhere.
There was a problem hiding this comment.
Was originally trying to implement this by partially running the same visitor logic. This was needed for that but I forgot to remove it when I found a simple way.
I'll remove it.
Codecov Report
@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 95.15% 95.15% -0.01%
==========================================
Files 363 363
Lines 20098 20138 +40
Branches 13 13
==========================================
+ Hits 19125 19162 +37
- Misses 973 976 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
anthony-c-martin
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added loop snippets to simplify loop authoring. The completions that insert the snippets are always available on module/resource values. On property value completions, we only include the loop snippet completion if the property is of array type and the new property loop won't be nested under an existing one.
This fixes #1616.