Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert playground to use vite instead of webpack #16341

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Feb 7, 2025

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test this change out locally with the following install scripts (Action run 13211962841)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13211962841
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13211962841"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13211962841
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13211962841"

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   32m 48s ⏱️ - 17m 7s
11 732 tests  -     13  11 732 ✅  -     13  0 💤 ±0  0 ❌ ±0 
27 222 runs   - 13 606  27 222 ✅  - 13 606  0 💤 ±0  0 ❌ ±0 

Results for commit f4208ac. ± Comparison against base commit e03c7bb.

This pull request removes 1796 and adds 611 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ
�0\u0010\u0000��>E�\u0003���\u0015��\u0008.>@lO��Z�
\u0005��M\u0007qiq�`�1w��\u001d\u0017���v\u000b6��&ZD|M�ب���=�0i\u00103o\u0014Q�4G\u0008��W��^7�r��q�\u000f�!�M�Č\u0008�P�\u0011%L
�f�r�d(�"\��\u001cgE
-�Է�Kχҗ~�7�3��Z�m�����\u0001�)���j�]6�e'�|�\u001f88\u0014Ж�4�� ?B\u0015l��^kx.]��y�7�\u0017(qW�\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K\u000e�0\u0010\u0006�=\u0005'(�2Ӗ\u0005{�^�Q\u0012\u001f�\u0018
��xw���\u0005�
�����L:}�<��~[�C�x��\���M\u0004
qt}\u0000\u0004\u000c�`B\u0013\u0011cI?�$#:��&���^?H�Ķ��,@g&7h\u000cp�I\u0002�&���5H��=\u0016��������nh��\u001a�>h4����uE��/�d���P)\u0005!��Ä�/��?�����\u0004Q\u0014E�\u001a�\u0017ʋ�\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��M\u000b�0\u0018\u0007��\u0014�\u0007���k�!�\u0011\u0016\u0004]c� \u0003-�@��7\u000f�E�\u0016��q{`�6�\u000f\u000cv�Y\u0019����<T$�`h��v��0\u0015\u0000�\u0017\u0004�`�\u0000�5�w��^պ��Lq�\u000f"��u��\u0008�P*I��\u0010#�\u0010�3�w���ʻ��\u001ceEj\u001ax��E[������N�����D��\u0008\u0005v\u00060�(�m�9�����L�y�\u001f~�\u001c\u0016�xy\﷉?��\u0004�vO��8�����Y�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Ի
�0\u0014\u0006��>E�\u0003ĤͭBw\u0017��\u0007��\u0011+���BA|w�A\Z\z\u0011�7d�9�\u0013�\u001f�ޛv\u000b&�ڒ�+�&hlԑ���w\u0018W��7��\u0012�!���'�q����(s���B�M�\u0017�0\u0015�Xs�\u0019�b\u001d2�W��\u000e�X�+Ӝ��̠%\u0017{+��b�}�kz\u0003>�7�\u0019��O#��\u001f ���-�J!]\u001e�,����?pp(�� m �Aq�:����Zx.=��y�7�\u00177I�\u0013\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003��K\u000e�0\u0010\u0006�=\u0005'(\u001d�i낽K��(��P\u000c�@b�����\u0005�
����m'3M�W�{��rw̫Z�h(�bn�i���\u0001\u0010\u00080/J(Cħ�~�IF�u�*\u001ee�^?(��k�E��I�֢�Jje4R����\u001eD7ל��_}�yy�K?\u0014\u0014S\u0005k_4\u0018��~���)�J%\u0002��\u0001BM������H&�<����\u0013\u0004A\u0010\u0004kx\u0002na.G\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003���
�@\u0010\u0000�=�\u0014�\u0003�;��\u0006\u001e�\u000e\u0019aA�5�\�@\u000b5\u0010z��CtQ��\u0005�w����̲�`o���V�.+\u001cP�<��F\u000cNi�}\u000b�@ ^\u0008"�q@�i\u0006�ý�UiZ���\u000f��,�\u0011�@��
	8���\u000cg&v�A��T}��"�
�TעM��ҿ�L����ƫ�i��O��\u0001\u000c\u0018��@�3&��O2��>�\u000f7N\u000e�M�<���ĝ;f\u0003��'˲,k|O�jT]\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createObject('key', 'value')","object","{
  key: 'value'
}")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\n")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\r\n")
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but don't really know what to look for.

@anthony-c-martin anthony-c-martin merged commit 8f4e885 into main Feb 8, 2025
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/vite branch February 8, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants