Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully qualified symbolic name to refer to copy loop in dependsOn #16236

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

jeskew
Copy link
Member

@jeskew jeskew commented Jan 28, 2025

Resolves #16230

#15910 updated copy loops on nested resources to use the fully qualified symbolic name of the resource as the copy loop name in order to fix a language version 2.0 breaking change (since lv 2.0 blocks duplicate copy loop names). However, that PR did not update how dependsOn is emitted in non-symbolic name templates (where a dependency on all members of a looped resource is expressed as a dependency on the copy loop name).

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested review from a team and Copilot January 28, 2025 18:36
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Test this change out locally with the following install scripts (Action run 13018304917)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13018304917
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13018304917"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13018304917
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13018304917"

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Dotnet Test Results

 0 tests  ± 0   0 ✅ ±0   0s ⏱️ ±0s
72 suites  - 45   0 💤 ±0 
74 files    - 43   0 ❌ ±0 
 2 errors

For more details on these parsing errors, see this check.

Results for commit 46fa2b6. ± Comparison against base commit e845112.

♻️ This comment has been updated with latest results.

# Conflicts:
#	src/Bicep.Core.IntegrationTests/ScenarioTests.cs
@jeskew jeskew enabled auto-merge (squash) January 28, 2025 19:27
@jeskew jeskew merged commit 7141454 into main Jan 28, 2025
42 of 43 checks passed
@jeskew jeskew deleted the jeskew/16230 branch January 28, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template reference is not valid when upgrading from 32.4 -> 33.13
2 participants