Reuse already updated object types when recursively removing type property flags

[jeskew]

Resolves #16219

The server crash reported in #16219 was caused by https://github.com/Azure/bicep/pull/15825/files#diff-7d66583c4922f57735a4eac96cd074d356e8eace34ec5900860f093f3d0cbc69R701. The FindPossibleSecretsVisitor relies on object identity to detect and stop infinitely walking recursive types, and the linked line caused otherwise identical object types within the assigned type of a resource symbol to have different identities.

Microsoft Reviewers: Open in CodeFlow

[github-actions]

Test this change out locally with the following install scripts (Action run 13017995567)

VSCode

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 13017995567

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 13017995567"

Azure CLI

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 13017995567

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 13017995567"

[github-actions]

Dotnet Test Results

 0 tests  ± 0   0 ✅ ±0   0s ⏱️ ±0s
75 suites  - 42   0 💤 ±0 
75 files    - 42   0 ❌ ±0 

Results for commit 2b64a1b. ± Comparison against base commit bfd6836.