Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case-insensitive equality operators to grammar #15640

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

GabinL21
Copy link
Contributor

@GabinL21 GabinL21 commented Nov 20, 2024

Resolves #15639

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew enabled auto-merge (squash) November 20, 2024 14:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.37%. Comparing base (108d816) to head (e8adbc6).
Report is 1452 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (108d816) and HEAD (e8adbc6). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (108d816) HEAD (e8adbc6)
dotnet 4 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #15640       +/-   ##
===========================================
- Coverage   94.28%    9.37%   -84.91%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      288   -100503     
  Branches     8734      123     -8611     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      261     -4334     
+ Partials     1168        0     -1168     
Flag Coverage Δ
dotnet ?
typescript 9.37% <ø> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1104 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@anthony-c-martin anthony-c-martin merged commit 6cf5576 into Azure:main Nov 21, 2024
39 of 40 checks passed
Copy link
Contributor

Test this change out locally with the following install scripts (Action run 11958091199)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 11958091199
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 11958091199"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 11958091199
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 11958091199"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-insensitive equality operators are missing in grammar.md
5 participants