Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15266 Completion for "resource<...>" should include the necessary str… #15267

Merged
merged 1 commit into from
Oct 16, 2024
Merged

15266 Completion for "resource<...>" should include the necessary str… #15267

merged 1 commit into from
Oct 16, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Oct 7, 2024 •
edited
Loading

Fixes #15266

Microsoft Reviewers: Open in CodeFlow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Test this change out locally with the following install scripts (Action run 11373443003)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 11373443003
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 11373443003"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 11373443003
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 11373443003"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

Dotnet Test Results

    72 files   -     36      72 suites   - 36   29m 45s ⏱️ - 10m 47s
11 357 tests  -     25  11 357 ✅  -     25  0 💤 ±0  0 ❌ ±0 
26 445 runs   - 13 218  26 445 ✅  - 13 218  0 💤 ±0  0 ❌ ±0 

Results for commit 6aaa5aa. ± Comparison against base commit 84c6efc.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford force-pushed the sw/241007-15266 branch 2 times, most recently from cebd821 to 12b2c1a Compare October 8, 2024 22:34
@StephenWeatherford StephenWeatherford merged commit 276f98a into main Oct 16, 2024
47 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/241007-15266 branch October 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

@jeskew jeskew Awaiting requested review from jeskew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completion for "resource<...>" should include the necessary string quotes
2 participants
@StephenWeatherford @shenglol