Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for microsoftGraph builtin extension #15149

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jason-dou
Copy link
Contributor

@jason-dou jason-dou commented Sep 25, 2024

Adding a deprecation warning for microsoftGraph builtin extension. Users should use dynamic types instead.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Test this change out locally with the following install scripts (Action run 11078340626)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 11078340626
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 11078340626"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 11078340626
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 11078340626"

Copy link
Contributor

Dotnet Test Results

    72 files   -     36      72 suites   - 36   25m 45s ⏱️ - 10m 24s
11 071 tests  -     25  11 071 ✅  -     25  0 💤 ±0  0 ❌ ±0 
25 907 runs   - 12 949  25 907 ✅  - 12 949  0 💤 ±0  0 ❌ ±0 

Results for commit aa5e48b. ± Comparison against base commit 02f6ec3.

@jason-dou jason-dou requested a review from shenglol September 25, 2024 22:11
@jason-dou jason-dou marked this pull request as ready for review September 25, 2024 22:11
@shenglol shenglol merged commit 1988aa8 into main Sep 27, 2024
47 checks passed
@shenglol shenglol deleted the jasondou/graph-dynamictypes-warn branch September 27, 2024 22:10
@alex-frankel
Copy link
Collaborator

Can we have an auto-fix to move users to the new format? I worry ppl might get tripped up on the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants