Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding none in the suggested completions list #14988

Conversation

polatengin
Copy link
Member

@polatengin polatengin commented Sep 5, 2024

Closes #14987

Adding none option to the code completion list for using keyword in .bicepparam files

Current behavior;

image

Expected behavior;

image

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Test this change out locally with the following install scripts (Action run 10760253713)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10760253713
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10760253713"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10760253713
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10760253713"

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Dotnet Test Results

    71 files   -     37      71 suites   - 37   25m 13s ⏱️ - 9m 29s
11 046 tests  -     19  11 046 ✅  -     19  0 💤 ±0  0 ❌ ±0 
25 868 runs   - 12 927  25 868 ✅  - 12 927  0 💤 ±0  0 ❌ ±0 

Results for commit 1a8d1f4. ± Comparison against base commit 3e4958e.

♻️ This comment has been updated with latest results.

@polatengin polatengin marked this pull request as ready for review September 6, 2024 19:57
…missing-none-completion-suggestion-for-using-syntaxes
@polatengin polatengin marked this pull request as draft September 6, 2024 20:08
@polatengin polatengin marked this pull request as ready for review September 6, 2024 21:54
@polatengin polatengin merged commit 6f3ea76 into main Sep 8, 2024
47 checks passed
@polatengin polatengin deleted the polatengin/14987-extendable-param-files-add-missing-none-completion-suggestion-for-using-syntaxes branch September 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Extendable Param Files] Add missing none completion suggestion for using syntaxes
2 participants