Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minutes in VS Code default bicep deployment name #14764

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Strandfelt
Copy link
Contributor

@Strandfelt Strandfelt commented Aug 7, 2024

Fixes #14763

Microsoft Reviewers: Open in CodeFlow

@Strandfelt Strandfelt changed the title Use minutes in default bicep deployment name Use minutes in VS Code default bicep deployment name Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.37%. Comparing base (108d816) to head (17579c3).
Report is 958 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (108d816) and HEAD (17579c3). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (108d816) HEAD (17579c3)
dotnet 4 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #14764       +/-   ##
===========================================
- Coverage   94.28%    9.37%   -84.91%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      288   -100503     
  Branches     8734      121     -8613     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      261     -4334     
+ Partials     1168        0     -1168     
Flag Coverage Δ
dotnet ?
typescript 9.37% <ø> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1107 files with indirect coverage changes

Copy link
Member

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking down this bug and fixing it!

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for fixing this!

@anthony-c-martin anthony-c-martin merged commit b1e3768 into Azure:main Aug 7, 2024
37 checks passed
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Test this change out locally with the following install scripts (Action run 10287978972)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10287978972
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10287978972"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10287978972
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10287978972"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Deploy with bicep" VS Code task default deployment name uses month twice
4 participants