Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle special characters in use-safe-access rule correctly #14593

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jul 19, 2024

I noticed that the safe access code fix is not suggesting the correct replacement for property access containing special characters. This PR fixes that.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Test this change out locally with the following install scripts (Action run 10010015603)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10010015603
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10010015603"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10010015603
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10010015603"

Copy link
Contributor

Dotnet Test Results

    72 files   -     35      72 suites   - 35   23m 30s ⏱️ - 10m 8s
10 968 tests  -     18  10 968 ✅  -     18  0 💤 ±0  0 ❌ ±0 
25 816 runs   - 12 898  25 816 ✅  - 12 898  0 💤 ±0  0 ❌ ±0 

Results for commit e746d56. ± Comparison against base commit 57a44c0.

@anthony-c-martin anthony-c-martin merged commit cdb0fd7 into main Jul 19, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/safe_access branch July 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants