Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure \n is used when emitting template #14581

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Jul 17, 2024

Currently, Bicep generates inconsistent newlines depending on whether the template is built using the Build command (and with or without the --stdout flag) or through the VS Code extension.

This PR updates the emission code to consistently use \n for newlines. This change should prevent issues like #14383 in the future.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Test this change out locally with the following install scripts (Action run 9982991637)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9982991637
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9982991637"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9982991637
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9982991637"

Copy link
Contributor

Dotnet Test Results

    72 files   -     36      72 suites   - 36   23m 27s ⏱️ - 10m 2s
10 955 tests  -     20  10 955 ✅  -     19  0 💤 ±0  0 ❌  - 1 
25 806 runs   - 12 899  25 806 ✅  - 12 898  0 💤 ±0  0 ❌  - 1 

Results for commit 0e2f891. ± Comparison against base commit 00a5bc4.

@shenglol shenglol merged commit ac8392e into main Jul 17, 2024
44 checks passed
@shenglol shenglol deleted the shenglol/consistent-newline-emission branch July 17, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants