Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Variable Symbol Access from within user defined functions #14531

Merged
merged 9 commits into from
Aug 27, 2024

Conversation

tsmallig33
Copy link
Contributor

@tsmallig33 tsmallig33 commented Jul 11, 2024

  1. Allow variable access from within user defined functions
  2. Update Azure.Deployments.* to 1.65.0

Waiting on ARM/Deployments release before merging

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Test this change out locally with the following install scripts (Action run 10581938824)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10581938824
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10581938824"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10581938824
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10581938824"

Copy link
Contributor

github-actions bot commented Jul 11, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   24m 54s ⏱️ - 8m 13s
11 050 tests  -     18  11 050 ✅  -     18  0 💤 ±0  0 ❌ ±0 
25 876 runs   - 12 928  25 876 ✅  - 12 928  0 💤 ±0  0 ❌ ±0 

Results for commit 57a0962. ± Comparison against base commit f5a2984.

♻️ This comment has been updated with latest results.

@tsmallig33 tsmallig33 marked this pull request as ready for review July 11, 2024 18:10
@tsmallig33 tsmallig33 marked this pull request as draft July 11, 2024 18:15
@tsmallig33 tsmallig33 added the do not merge Do not merge this pull request yet. label Jul 11, 2024
@tsmallig33 tsmallig33 marked this pull request as ready for review July 11, 2024 19:10
@tsmallig33 tsmallig33 requested a review from jeskew July 11, 2024 20:38
jeskew
jeskew previously approved these changes Jul 11, 2024
@jeskew jeskew dismissed their stale review July 11, 2024 20:40

Clicked the wrong button

@tsmallig33 tsmallig33 changed the title Tasmalligan/variable access in udf Tasmalligan/Allow Variable Symbol Access from within user defined functions and update Azure.Deployments.* to 1.65.0 Jul 15, 2024
@tsmallig33 tsmallig33 changed the title Tasmalligan/Allow Variable Symbol Access from within user defined functions and update Azure.Deployments.* to 1.65.0 Allow Variable Symbol Access from within user defined functions and update Azure.Deployments.* to 1.65.0 Aug 8, 2024
@tsmallig33 tsmallig33 changed the title Allow Variable Symbol Access from within user defined functions and update Azure.Deployments.* to 1.65.0 Allow Variable Symbol Access from within user defined functions Aug 27, 2024
@jeskew jeskew removed the do not merge Do not merge this pull request yet. label Aug 27, 2024
@tsmallig33 tsmallig33 merged commit 4cb0728 into main Aug 27, 2024
47 checks passed
@tsmallig33 tsmallig33 deleted the tasmalligan/VariableAccessInUDF branch August 27, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants