Support "Local Deploy" in the VSCode Deployment Pane #14234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-c-martin
force-pushed
the
localdeploy
branch
2 times, most recently
from
a50bb9b to
b08a37a
Compare
|
Test this change out locally with the following install scripts (Action run 9452446344) VSCode
Azure CLI
|
anthony-c-martin
force-pushed
the
localdeploy
branch
10 times, most recently
from
33296a1 to
d75d073
Compare
anthony-c-martin
force-pushed
the
localdeploy
branch
from
d75d073 to
f93946f
Compare
anthony-c-martin
changed the title
anthony-c-martin
force-pushed
the
localdeploy
branch
from
f93946f to
833c1ec
Compare
shenglol
reviewed
Jun 7, 2024
| ); | ||
| } | ||
|
|
||
| export function getLocalDeployOutputs(result: LocalDeployResponse) { |
There was a problem hiding this comment.
It might be worth changing these functions into components as a best practice to avoid unnecessary rendering.
There was a problem hiding this comment.
Pushed a change - is that what you were thinking?
|
So excited to use this one personally :) What is the procedure (as a user) going to be for enabling this? |
shenglol
reviewed
Jun 10, 2024
| } | ||
|
|
||
|
|
||
| export const LocalDeployOutputs: FC<{ result: LocalDeployResponse }> = ({ result }) => { |
There was a problem hiding this comment.
Using FC was not recommended because it implicitly includes the children prop type, but it seems React 18 fixed the problem, so we should be fine: https://www.totaltypescript.com/you-can-stop-hating-react-fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-01-08.at.11.40.02.AM.mov
Microsoft Reviewers: Open in CodeFlow