Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BCP395 error message #14094

Merged
merged 1 commit into from
May 13, 2024
Merged

Improve BCP395 error message #14094

merged 1 commit into from
May 13, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented May 13, 2024

Closes #13672.

Microsoft Reviewers: Open in CodeFlow

@shenglol shenglol enabled auto-merge (squash) May 13, 2024 22:27
Copy link
Contributor

github-actions bot commented May 13, 2024

Test this change out locally with the following install scripts (Action run 9070755190)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9070755190
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9070755190"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9070755190
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9070755190"

Copy link
Contributor

Dotnet Test Results

    66 files   -     33      66 suites   - 33   22m 13s ⏱️ - 10m 19s
10 890 tests  -     20  10 889 ✅  -     20  1 💤 ±0  0 ❌ ±0 
25 676 runs   - 12 834  25 674 ✅  - 12 833  2 💤  - 1  0 ❌ ±0 

Results for commit 9bb639f. ± Comparison against base commit cd8ad8a.

@shenglol shenglol merged commit 77ca6f5 into main May 13, 2024
44 checks passed
@shenglol shenglol deleted the shenglol/improve-bcp395 branch May 13, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message of BCP395
2 participants