New Example: SIG with Image Definition and Role Assignment #1251
Conversation
…ignment New Example: Shared Image Gallery with Image Defintition and Role Assignment
Codecov Report
@@ Coverage Diff @@
## main #1251 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 336 336
Lines 16835 16835
Branches 14 14
=======================================
Hits 15908 15908
Misses 927 927
Flags with carried forward coverage won't be shown. Click here to find out more. |
| param principalID string | ||
| param templateImageResourceGroup string | ||
|
|
||
| var assignableScopes = '/subscriptions/${azureSubscriptionID}/resourcegroups/${templateImageResourceGroup}' |
There was a problem hiding this comment.
since this is just a single value, I would say assignableScope or possibly something like imageResourceGroupId to be more specific.
I'm assuming that this resourceGroup could be in a different rg than the target of the deployment? Otherwise, you could use resourceGroup().id
There was a problem hiding this comment.
Thanks, that makes sense! I changed it to templateImageResourceGroupId to match the existing parameter templateImageResourceGroup.
|
|
||
| //create role assignment | ||
| resource galleryass 'Microsoft.Authorization/roleAssignments@2020-04-01-preview' = { | ||
| name: guid(resourceGroup().id) |
There was a problem hiding this comment.
This guid() function needs some more arguments. If I did another role assignment to the same rg with different properties and used only the rg id as an argument, I would get a conflict. I'd recommend adding the roleDefinition id and principal id:
guid(resourceGroup().id, gallerydef.id, principalId)
Processed suggested changes
Now also updating the transpiled json result
New Example: Shared Image Gallery with Image Definition and Role Assignment