adding batch account template #1222
Conversation
| } | ||
| } | ||
|
|
||
| output batchaccountFQDN string = batchaccount.properties.accountEndpoint |
There was a problem hiding this comment.
You need a blank line after line 20 to pass the formatting test
There was a problem hiding this comment.
@alex-frankel , Tried adding the blank line but the cursor hits back at the end of line 20 as soon as I save the file. Could you please let me know if I am missing onto something basic? Thank you.
There was a problem hiding this comment.
You might have this setting enabled:
|
Looks like you also need to rerun |
|
@alex-frankel , Thanks for the quick help! I updated the new line formatting and reran the build command too. Does this look to be correct? |
| default: 'BatchService' | ||
| allowed: [ | ||
| 'BatchService' | ||
| 'Usersubscription' |
There was a problem hiding this comment.
You are getting a warning because the casing is not correct. Change 'Usersubscription' => 'UserSubscription'.
| } | ||
| }, | ||
| "functions": [], | ||
| "variables": {}, |
There was a problem hiding this comment.
I had to rerun bicep build to get rid of this line which was the reason your test was failing. Ensure you are using bicep v0.2.212 as we have updated the ARM Template generation logic. A bicep file with no vars should result in an ARM Template with no "variables"
Codecov Report
@@ Coverage Diff @@
## main #1222 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 336 336
Lines 16825 16835 +10
Branches 14 14
=======================================
+ Hits 15898 15908 +10
Misses 927 927
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@alex-frankel , thank you for pointing to right direction, I could successfully complete the tests after updating the required changes. |
Adding Bicep template to create azure batch account with batch service pool allocation mode.