Fixed declaration type completions when extra whitespace is present #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
commented
Dec 10, 2020
| @@ -153,70 +153,54 @@ private static List<SyntaxBase> FindNodesMatchingOffset(ProgramSyntax syntax, in | |||
|
|
|||
| private static BicepCompletionContextKind GetDeclarationTypeFlags(IList<SyntaxBase> matchingNodes, int offset) | |||
| { | |||
| if (matchingNodes.Count < 2) | |||
| // local function | |||
| bool CheckTypeIsExpected(SyntaxBase name, SyntaxBase type) => name.Span.Length > 0 && offset > name.Span.Position + name.Span.Length && offset <= type.Span.Position; | |||
There was a problem hiding this comment.
The fix was to adjust the condition in this function (the commit called "fix" covers it... mostly). All other changes in this file are just a refactor to change this logic to use the tail matcher.
Codecov Report
@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 94.27% 94.26% -0.01%
==========================================
Files 328 328
Lines 15856 15853 -3
Branches 12 12
==========================================
- Hits 14948 14944 -4
- Misses 908 909 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
anthony-c-martin
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #718. Also refactored some of the completion logic to use the newer style.