Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set intellisense defaults #1019

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Set intellisense defaults #1019

merged 2 commits into from
Nov 27, 2020

Conversation

majastrz
Copy link
Member

@majastrz majastrz commented Nov 26, 2020

Set the following IntelliSense defaults for Bicep language in the VS code extension:

  • Choose first selection in completion list (we have observed strange VS code behavior with other settings)
  • Allow completions to work inside an active snippet
  • Disables text-based completions.

This fixes #882

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #1019 (3b5667c) into main (a0a38b2) will increase coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
+ Coverage   94.26%   94.72%   +0.46%     
==========================================
  Files         328      324       -4     
  Lines       15810    15670     -140     
  Branches       12        0      -12     
==========================================
- Hits        14903    14844      -59     
+ Misses        907      826      -81     
Flag Coverage Δ
dotnet 94.72% <ø> (-0.10%) ⬇️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cep.Core.UnitTests/FileSystem/FileResolverTests.cs 79.31% <0.00%> (-20.69%) ⬇️
.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs 63.63% <0.00%> (-15.91%) ⬇️
src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs 20.00% <0.00%> (-13.34%) ⬇️
src/Bicep.Core/FileSystem/PathHelper.cs 96.15% <0.00%> (-3.85%) ⬇️
...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs 100.00% <0.00%> (ø)
src/vscode-bicep/src/extension.ts
src/vscode-bicep/src/language/client.ts
src/vscode-bicep/src/utils/telemetry.ts
src/vscode-bicep/src/utils/logger.ts

@majastrz majastrz marked this pull request as ready for review November 26, 2020 12:27
@majastrz majastrz merged commit 1211432 into main Nov 27, 2020
@majastrz majastrz deleted the majastrz/intellisense-defaults branch November 27, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable naive vs code intellisense by default
3 participants