Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep file that creates a basic WVD Backplane #1003

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Bicep file that creates a basic WVD Backplane #1003

merged 5 commits into from
Nov 25, 2020

Conversation

fberson
Copy link
Contributor

@fberson fberson commented Nov 25, 2020

This Bicep creates a WVD Backplane in Azure consisting of :

  • WVD Hostpool
  • WVD AppGroup
  • WVD Workspace
  • A configured relationship between these objects.

This Bicep creates a WVD Backplane in Azure consisting of :
- WVD Hostpool
- WVD AppGroup
- WVD Workspace
- A configured relationship between these objects.
This main bicep file creates a WVD environment in Azure, based on Bicep 0.2 creating Resource Groups, WVD Backplane components, Vnet with Subnet, Storage container with FileShare and Log Analytics Workspace. This main bicep files calls the bicep modules as outlined below.

 - wvd-backplane-module.bicep
 - wvd-network-module.bicep
 - wvd-fileservices-module.bicep
 - wvd-LogAnalytics.bicep
 - wvd-monitor-diag.bicep
@anthony-c-martin
Copy link
Member

@fberson, thank you for contributing!

Just FYI to fix up the test failures:

  1. The build expects to see a .json file for each .bicep file checked in, so you'll need to include those, even for the individual module files. If you have .NET 5 installed locally, you can fix all at once with dotnet test -- 'TestRunParameters.Parameter(name=\"SetBaseLine\", value=\"true\")' in the root of the repo, otherwise you can just run bicep build for each of the module files.
  2. There is a 'missing type' warning which is also blocking check-in. You can fix that by copying one of the entries here and adding one for Microsoft.DesktopVirtualization/hostpools/providers/diagnosticSettings@2017-05-01-preview:
    https://github.com/Azure/bicep/blob/main/src/Bicep.Core.Samples/ExamplesTests.cs#L84-L101

@fberson
Copy link
Contributor Author

fberson commented Nov 25, 2020

@anthony-c-martin I added the required .json file for the .bicep file and reverted the module project to create individual later, but I still see failures? Can you help?

@anthony-c-martin
Copy link
Member

@anthony-c-martin I added the required .json file for the .bicep file and reverted the module project to create individual later, but I still see failures? Can you help?

Ah yes, I forgot to mention. The tests are also very fussy about the format of the .bicep file - just to enforce consistency in the samples. I used the VSCode "Format Document" command on your file and have checked in the updated file to your branch.

We've got some info on the various Examples validations here: https://github.com/Azure/bicep/blob/main/CONTRIBUTING.md#example-files

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for contributing!

@anthony-c-martin anthony-c-martin merged commit 018b398 into Azure:main Nov 25, 2020
@fberson
Copy link
Contributor Author

fberson commented Nov 25, 2020

Thanks @anthony-c-martin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants