Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy: Can't tell what parameter is being asked for when it has a default value #8028

Closed
StephenWeatherford opened this issue Aug 19, 2022 · 1 comment · Fixed by #8040
Closed

Deploy: Can't tell what parameter is being asked for when it has a default value #8028

StephenWeatherford opened this issue Aug 19, 2022 · 1 comment · Fixed by #8040
Assignees
@StephenWeatherford
Labels
devdiv Related to Bicep tooling efforts in DevDiv P1 This is planned to be completed before the end of a release story: bicep deploy
Milestone
v0.10

Comments

@StephenWeatherford
Copy link
Contributor

This is a bug in @microsoft/vscode-azext-utils that was exposed by my fix to #7639. It's because @microsoft/vscode-azext-utils is not honoring the inputbox title. When there's a default value, we show that in the inputbox and so the watermark prompt doesn't show up. But since with my fix to #7639 the title no longer shows up, there's nothing mentioning the current parameter name.

To fix I need to update to current @microsoft/vscode-azext-utils version and then fix it there and update again.

Previous behavior:
image

Current behavior:
image
@ghost ghost added the Needs: Triage 🔍 label Aug 19, 2022
@StephenWeatherford StephenWeatherford self-assigned this Aug 19, 2022
@StephenWeatherford StephenWeatherford added P1 This is planned to be completed before the end of a release devdiv Related to Bicep tooling efforts in DevDiv story: bicep deploy and removed Needs: Triage 🔍 labels Aug 19, 2022
@StephenWeatherford StephenWeatherford moved this to Todo in Bicep Aug 19, 2022
@StephenWeatherford StephenWeatherford added this to the v0.10 milestone Aug 19, 2022
@StephenWeatherford StephenWeatherford moved this from Todo to In Progress in Bicep Aug 19, 2022
@StephenWeatherford
Copy link
Contributor Author

Already on current version.

@StephenWeatherford StephenWeatherford mentioned this issue Aug 19, 2022
Closed
StephenWeatherford added a commit that referenced this issue Aug 19, 2022
@StephenWeatherford
Fix #8028
bc8fb60
@StephenWeatherford StephenWeatherford mentioned this issue Aug 19, 2022
Merged
Repository owner moved this from In Progress to Done in Bicep Aug 22, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenWeatherford StephenWeatherford

Labels
devdiv Related to Bicep tooling efforts in DevDiv P1 This is planned to be completed before the end of a release story: bicep deploy
Projects
Bicep
Archived in project
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

Fix #8028 Azure/bicep
1 participant
@StephenWeatherford