-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform/notify users in VS Code when a newer module version is available #13553
Labels
devdiv
Related to Bicep tooling efforts in DevDiv
enhancement
New feature or request
investigate
P1
This is planned to be completed before the end of a release
story: linter rules
Milestone
Comments
Great request, would love to have this implemented! |
Issues:
|
Decisions so far:
|
Issues:
|
We should be able to rely upon semantic versioning here for comparisons as we cannot update an existing version in the MCR without a lot of manual work, so we actually prevent this in the CI. The CI also guarantees the formatting of the tags etc. |
StephenWeatherford
added a commit
that referenced
this issue
Jun 29, 2024
Fixes #13553 Most changes are packages.lock.json and tests - PublicRegistryModuleMetadata* -> moved to Bicep.Core - IPublicRegistryModuleMetadataProvider -> changed so that it returns only what's currently in the cache at a given time (although it'll start a cache update in the background). - Linter rules can now access an IServiceProvider - New linter rule does not download module metadata info itself, but just uses current cache. Will display a warning until the cache is downloaded. - PublicRegistryModuleMetadataProvider worked into the artifact restoration process of OCI artifacts (as discussed in Bicep meeting). This way, the linter rule will not hold up compilation, and uses can make sure the cache is not downloaded using --no-restore (although in the current iteration there's no cache on disk so it will give an error in that mode from CLI - this could change in the future). - Only handles public modules for now, but is designed to be able to deal with private registries later ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/14309) --------- Co-authored-by: Stephen Weatherford <Stephen.Weatherford.com> Co-authored-by: Shenglong Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devdiv
Related to Bicep tooling efforts in DevDiv
enhancement
New feature or request
investigate
P1
This is planned to be completed before the end of a release
story: linter rules
Is your feature request related to a problem? Please describe.
It'd be nice to add a new feature to suggest users leveraging the latest version of a module from the Public Bicep Registry. Opening this issue is a follow up to a chat/brainstorm with @shenglol on user experience of consuming AVM modules.
Describe the solution you'd like
A possible solution in VS Code would give users a range of visual notifications when:
The levels of notifications, their visibility should be configurable. The intent is to inform the users about the latest available module versions and suggest they should learn more about them and their new features.
The text was updated successfully, but these errors were encountered: