Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 2 hour delay before cleanup #2937

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Added 2 hour delay before cleanup #2937

merged 3 commits into from
Jan 5, 2024

Conversation

jeff-shepherd
Copy link
Contributor

Description

Delay cleanup by 2 hours so that entities are not deleted while they are still in use.

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

rdondera-microsoft
rdondera-microsoft approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@rdondera-microsoft rdondera-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two questions:

  1. Is there a way to test this before it is deployed?
  2. Is there a way to make other developers aware that their jobs must not straddle the interval 12am-2am?

cli/cleanup.sh Outdated Show resolved Hide resolved
@jeff-shepherd jeff-shepherd merged commit 6947079 into main Jan 5, 2024
357 of 386 checks passed
@jeff-shepherd jeff-shepherd deleted the jeffshep/delaycleanup branch January 5, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diondrapeck diondrapeck diondrapeck approved these changes

@rdondera-microsoft rdondera-microsoft rdondera-microsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-shepherd @diondrapeck @rdondera-microsoft