Improve function factories #4558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
There was a problem hiding this comment.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- v2/tools/generator/internal/functions/object_function.go: Evaluated as low risk
- v2/tools/generator/internal/functions/resource_function.go: Evaluated as low risk
- v2/tools/generator/internal/armconversion/arm_spec_interface.go: Evaluated as low risk
- v2/tools/generator/internal/functions/kubernetes_admissions_validator.go: Evaluated as low risk
- v2/tools/generator/internal/codegen/pipeline/add_status_conditions.go: Evaluated as low risk
- v2/tools/generator/internal/codegen/pipeline/inject_property_assignment_functions.go: Evaluated as low risk
- v2/tools/generator/internal/functions/kubernetes_admissions_defaulter.go: Evaluated as low risk
- v2/tools/generator/internal/functions/kubernetes_config_exporter_function.go: Evaluated as low risk
- v2/tools/generator/internal/functions/dynamic_exports.go: Evaluated as low risk
- v2/tools/generator/internal/interfaces/kubernetes_resource_interface.go: Evaluated as low risk
- v2/tools/generator/internal/functions/get_resource_type_function.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
v2/tools/generator/internal/functions/new_empty_arm_value_function.go:25
- The NewObjectFunction call should include the package reference as a variadic argument, but the existing code already handles this correctly. No changes are needed here.
newEmptyARMValueBody(armType),
3f8b56e to
c4634fc
Compare
theunrepentantgeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Minor quality-of-life improvement for the
NewResourceFunction()andNewObjectFunction()methods, making code easier to read by removing boilerplate.How does this PR make you feel?