Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our azure-rest-api-specs submodule #4386

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Oct 28, 2024

What this PR does

Updates the commit referenced by the v2/specs/azure-rest-api-specs submodule to the latest main and regenerates code.

Breaking: The property RouteTablesRoute.HasBgpOverride has been marked as readonly by the upstream product group (see commit 61fdc46from PR#29993) and has been removed from our Spec definitions.

How does this PR make you feel?

gif

@theunrepentantgeek theunrepentantgeek added the breaking A change which likely be breaking label Oct 28, 2024
@theunrepentantgeek theunrepentantgeek self-assigned this Oct 28, 2024
@theunrepentantgeek theunrepentantgeek added this to the v2.11.0 milestone Oct 28, 2024
@matthchr
Copy link
Member

Looks like you need to re-record a test (or manually edit the recording file to remove that removed field)

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2024
@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Oct 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
* Update submodule reference

* Regenerate api/containerservice

* Regenerate api/insights

* Regenerate api/machinelearningservices

* Regenerate api/network

* Update test recording
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2024
@matthchr matthchr added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 6e7915f Oct 30, 2024
7 checks passed
@matthchr matthchr deleted the feature/update-azure-rest-api-specs branch October 30, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change which likely be breaking
Projects
Development

Successfully merging this pull request may close these issues.

2 participants